-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix dwi
module function cross ref in docstring
#103
DOC: Fix dwi
module function cross ref in docstring
#103
Conversation
Looks like the documentation is not being built correctly: Was already happening before: The readthedocs log shows multiple failures related to the Should be addressed in a separate PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 58.27% 58.43% +0.16%
==========================================
Files 22 22
Lines 2085 2086 +1
Branches 321 364 +43
==========================================
+ Hits 1215 1219 +4
+ Misses 787 783 -4
- Partials 83 84 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fix `dwi` module function cross ref in docstring: provide the appropriate module where `draw_points` dwells. Introduced inadvertently in commit 9f561d1 when the code was relocated from `eddymotion`. Take advantage of the commit to improve the description of the method: - Specify how the colors are assigned. - Cross-reference the `draw_points` function using the Sphinx `seealso` tag. - Use the tilde to shorten the link: display only the function name without the modules.
178b195
to
4340f64
Compare
I think the problem is that we import from the package in |
Hmm, no it is installed. Possibly the autodoc mock is interfering? |
Looks like that fixed it: https://nireports--103.org.readthedocs.build/en/103/api/nireports.interfaces.dmri.html (I had to refresh the cache to see it.) |
I fixed a couple small errors that were preventing the admonitions from being shown. Let me know if you'd rather they be pulled into a different PR. |
Fine with me. Thanks for the investigation on the documentation failures Chris. Will merge as soon as soon as CIs become green. |
Fix
dwi
module function cross ref in docstring: provide the appropriate module wheredraw_points
dwells.Introduced inadvertently in commit 9f561d1 when the code was relocated from
eddymotion
.Take advantage of the commit to improve the description of the method:
draw_points
function using the Sphinxseealso
tag.