ENH: Catch warning when loaded text file contains no data in test #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
AvoidEmptyTxtLoadWarning
branch
from
47d7ff0 to
868d7ae
Compare
jhlegarreta
force-pushed
the
AvoidEmptyTxtLoadWarning
branch
from
868d7ae to
4c7735b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 65.25% 64.43% -0.83%
==========================================
Files 25 25
Lines 2674 2674
Branches 420 367 -53
==========================================
- Hits 1745 1723 -22
- Misses 814 838 +24
+ Partials 115 113 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Resolved conflicts, push-forced, codecov is happy now. Ready to be merged. |
effigies
reviewed
Jan 12, 2025
Catch warning when loaded text file contains no data in test.
Fixes:
```
nireports/tests/test_reportlets.py::test_plot_melodic_components
/home/runner/work/nireports/nireports/nireports/reportlets/xca.py:128:
UserWarning: loadtxt: input contained no data:
"/tmp/pytest-of-runner/pytest-0/popen-gw0/test_plot_melodic_components0/noise_none.csv"
noise_components = np.loadtxt(noise_components_file, dtype=int, delimiter=",", ndmin=1)
```
raised for example in:
https://github.com/nipreps/nireports/actions/runs/12681153218/job/35344304375#step:12:347
jhlegarreta
force-pushed
the
AvoidEmptyTxtLoadWarning
branch
from
4c7735b to
30b5a91
Compare
effigies
reviewed
Feb 8, 2025
|
Sorry, didn't realize this would fail on min. Feel free to revert and merge. |
effigies
force-pushed
the
AvoidEmptyTxtLoadWarning
branch
from
b34a89b to
30b5a91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch warning when loaded text file contains no data in test.
Fixes:
raised for example in:
https://github.com/nipreps/nireports/actions/runs/12681153218/job/35344304375#step:12:347