ENH: Close all Matplotlib figures in relevant tests explicitly
#167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 66.04% 66.41% +0.37%
==========================================
Files 25 25
Lines 2677 2677
Branches 421 421
==========================================
+ Hits 1768 1778 +10
+ Misses 793 788 -5
+ Partials 116 111 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Oh, does not fix issues, and the ones in 15f4898 are still there: Not sure how to fix this otherwise. Marking as draft. |
jhlegarreta
force-pushed
the
CloseFiguresExplicitly3
branch
2 times, most recently
from
524458c to
cb97b95
Compare
jhlegarreta
changed the title
Matplotlib figures in relevant tests explicitly
Close all `Matplotlib` figures in relevant tests explicitly: when the `output_file` argument is `None` the `plot_carpet` method does not close figures, and thus a warning is raised if the number of open figures exceeds a given value. Use `all` explicitly to guarantee all figures are closed. This change fixes the warnings that have persisted despite commits 626dd35 and 15f4898 claiming to fix these issues. Fixes: ``` nireports/tests/test_reportlets.py::test_nifti_carpetplot /home/runner/work/nireports/nireports/nireports/reportlets/nuisance.py:326: RuntimeWarning: More than 20 figures have been opened. Figures created through the pyplot interface (`matplotlib.pyplot.figure`) are retained until explicitly closed and may consume too much memory. (To control this warning, see the rcParam `figure.max_open_warning`). Consider using `matplotlib.pyplot.close()`. figure, allaxes = plt.subplots(figsize=(19.2, 10)) ``` and similar warnings. Raised for example in: https://github.com/nipreps/nireports/actions/runs/13276183449/job/37066107605#step:14:341
jhlegarreta
force-pushed
the
CloseFiguresExplicitly3
branch
from
cb97b95 to
771f87c
Compare
|
Perhaps a safer way of doing this is a fixture that ensures figures are closed after every test. That said, this one effectively resolves the issue. I'll merge and leave the safer option for our future selves. Thanks! |
oesteban
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close all
Matplotlibfigures in relevant tests explicitly: when theoutput_fileargument isNonetheplot_carpetmethod does not close figures, and thus a warning is raised if the number of open figures exceeds a given value.Use
allexplicitly to guarantee all figures are closed. This change fixes the warnings that have persisted despite commits 626dd35 and 15f4898 claiming to fix these issues.Fixes:
and similar warnings.
Raised for example in:
https://github.com/nipreps/nireports/actions/runs/13276183449/job/37066107605#step:14:341