ENH: Use a fixture to close Matplotlib figures in tests

[jhlegarreta]

Use a fixture to close Matplotlib figures in tests.

Resolves #168.

[jhlegarreta]

Is there a reason why there is two conftest.py files?
https://github.com/nipreps/nireports/blob/main/nireports/conftest.py
https://github.com/nipreps/nireports/blob/main/nireports/tests/conftest.py

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.38%. Comparing base (8a69b48) to head (1973f60).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   66.04%   66.38%   +0.33%     
==========================================
  Files          25       25              
  Lines        2677     2677              
  Branches      421      421              
==========================================
+ Hits         1768     1777       +9     
+ Misses        793      788       -5     
+ Partials      116      112       -4     

Flag	Coverage Δ
unittests	61.33% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jhlegarreta]

Working, e.g.
https://github.com/nipreps/nireports/actions/runs/13355051658/job/37296637850?pr=169#step:14:332
https://github.com/nipreps/nireports/actions/runs/13355051658/job/37296638147?pr=169#step:14:332

[effigies]

Is there a reason why there is two conftest.py files? https://github.com/nipreps/nireports/blob/main/nireports/conftest.py https://github.com/nipreps/nireports/blob/main/nireports/tests/conftest.py

It's just scoping. nireports.tests.conftest applies to nireports.tests and nireports.conftest applies to all of nireports. There's no strict need to split things up this way, although when writing fixtures, some do make sense to have a narrower scope.

[jhlegarreta]

It's just scoping. nireports.tests.conftest applies to nireports.tests and nireports.conftest applies to all of nireports. There's no strict need to split things up this way, although when writing fixtures, some do make sense to have a narrower scope.

OK. IMO having a nireports.conftest.py reads weird as a conftest.py is supposed to apply to tests.

[jhlegarreta]

Still working:
https://github.com/nipreps/nireports/actions/runs/13355684650/job/37298104924?pr=169#step:14:331
https://github.com/nipreps/nireports/actions/runs/13355684650/job/37298105287?pr=169#step:14:331

[oesteban]

OK. IMO having a nireports.conftest.py reads weird as a conftest.py is supposed to apply to tests.

Agreed. However we still need fixtures for doctests.