MAINT: Fix deprecated seaborn function calls
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 66.04% 66.38% +0.33%
==========================================
Files 25 25
Lines 2677 2677
Branches 421 421
==========================================
+ Hits 1768 1777 +9
+ Misses 793 788 -5
+ Partials 116 112 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jhlegarreta
force-pushed
the
FixDeprecatedSnsFunctionCalls
branch
from
faa8a3f to
e69a319
Compare
Fix deprecated `seaborn` function calls: use `displot` or `histplot` where applicable instead of `distplot`, since the latter will be removed in `seaborn` v0.14.0. Adapt the corresponding calls where necessary adding reasonable keyword argument values. Fixes: ``` This function has been deprecated and will be removed in seaborn v0.14.0. It has been replaced by :func:`histplot` and :func:`displot`, two functions with a modern API and many more capabilities. ``` Documentation: https://gist.github.com/mwaskom/de44147ed2974457ad6372750bbe5751 Co-authored-by: Chris Markiewicz <[email protected]>
jhlegarreta
force-pushed
the
FixDeprecatedSnsFunctionCalls
branch
from
e69a319 to
59c1b4d
Compare
|
@effigies If the requested changes have been addressed, can we please merge this? |
|
It looks right, but this is untested code, and as far as I can tell, not used anywhere. I'm concerned that we will make changes and only discover bugs when someone starts trying to use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deprecated
seabornfunction calls: usedisplotorhistplotwhere applicable instead ofdistplot, since the latter will be removed inseabornv0.14.0.Adapt the corresponding calls where necessary adding reasonable keyword argument values.
Fixes:
Documentation:
https://gist.github.com/mwaskom/de44147ed2974457ad6372750bbe5751