-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure docker runtimes support dockerignore, empty build args and ignore other entrypoint files #703
Conversation
davemooreuws
commented
Mar 17, 2024
•
edited
Loading
edited
- Stops the CLI from breaking when no args are defined
- Allows .dockerignore to be used for default runtimes
- Allows a custom runtime to define a dockerignore by "[dockerfile]".dockerignore
- Adds other entrypoint files to dockerignore
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #703 +/- ##
========================================
+ Coverage 1.33% 1.42% +0.08%
========================================
Files 73 73
Lines 7342 7376 +34
========================================
+ Hits 98 105 +7
- Misses 7239 7263 +24
- Partials 5 8 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b35492f
to
5c14009
Compare
2bebdac
to
f480f08
Compare
🎉 This PR is included in version 1.37.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |