Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure docker runtimes support dockerignore, empty build args and ignore other entrypoint files #703

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

davemooreuws
Copy link
Member

@davemooreuws davemooreuws commented Mar 17, 2024

  • Stops the CLI from breaking when no args are defined
  • Allows .dockerignore to be used for default runtimes
  • Allows a custom runtime to define a dockerignore by "[dockerfile]".dockerignore
  • Adds other entrypoint files to dockerignore

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 17.94872% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 1.42%. Comparing base (8e4861d) to head (39a196e).

Files Patch % Lines
pkg/project/runtime/runtime.go 20.58% 24 Missing and 3 partials ⚠️
pkg/project/project.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #703      +/-   ##
========================================
+ Coverage   1.33%   1.42%   +0.08%     
========================================
  Files         73      73              
  Lines       7342    7376      +34     
========================================
+ Hits          98     105       +7     
- Misses      7239    7263      +24     
- Partials       5       8       +3     
Flag Coverage Δ
unittests 1.42% <17.94%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davemooreuws davemooreuws force-pushed the fix/empty-custom-runtime-args branch from b35492f to 5c14009 Compare March 18, 2024 00:08
@davemooreuws davemooreuws marked this pull request as draft March 18, 2024 01:23
@davemooreuws davemooreuws marked this pull request as ready for review March 18, 2024 02:35
@davemooreuws davemooreuws changed the title fix: ensure empty build args is allowed for custom docker runtimes fix: ensure docker runtimes support dockerignore and empty build args Mar 18, 2024
tjholm
tjholm previously requested changes Mar 18, 2024
@davemooreuws davemooreuws force-pushed the fix/empty-custom-runtime-args branch from 2bebdac to f480f08 Compare March 18, 2024 03:48
@davemooreuws davemooreuws requested a review from tjholm March 18, 2024 03:49
@davemooreuws davemooreuws changed the title fix: ensure docker runtimes support dockerignore and empty build args fix: ensure docker runtimes support dockerignore, empty build args and ignore other entrypoint files Mar 18, 2024
@davemooreuws davemooreuws requested a review from tjholm March 18, 2024 04:21
@davemooreuws davemooreuws dismissed tjholm’s stale review March 18, 2024 22:22

change applied

@tjholm tjholm merged commit 5c589ac into main Apr 2, 2024
6 checks passed
@tjholm tjholm deleted the fix/empty-custom-runtime-args branch April 2, 2024 03:11
@nitric-bot
Copy link
Contributor

🎉 This PR is included in version 1.37.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants