-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/dark mode : Added shadcn dark mode to dashboard #852
base: main
Are you sure you want to change the base?
Conversation
Thank you for the PR @aloktomarr Can you try testing with a running project that contains all the resources? There are some missing spots. For example: Go into I'll review what you can done so far. |
pkg/dashboard/frontend/src/components/architecture/nodes/NodeBase.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi David, Thank you for taking the time to review the PR. I have added the missing classes to the components, which should resolve the issues with dark mode. Please have a look and let me know if any further changes are needed. Thanks! |
Hi Alok, Thanks for the update! I appreciate you adding the missing classes to resolve some of the dark mode issues. I took a look at the changes, and I have a few suggestions to further align things with our design goals:
If you think it would help, I can submit a PR with these changes. Let me know what you think, or if you'd prefer to handle it yourself. Thanks again for your work on this! |
What does this PR do?
This PR adds dark mode support to the dashboard using shadcn/ui theme variables and next-themes for theme management.
Fixes #763
###Type of change
feature
Changes
Screenshots
[Add before/after screenshots showing light and dark modes]
Testing Done
Notes