Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/api cors #523

Closed
wants to merge 5 commits into from
Closed

Feat/api cors #523

wants to merge 5 commits into from

Conversation

davemooreuws
Copy link
Member

@davemooreuws davemooreuws commented Oct 19, 2023 •
edited
Loading

Closed for new PR

@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
cloud/gcp/runtime/gateway/http.go 31.42% <100.00%> (+1.19%) ⬆️
core/pkg/worker/route_worker.go 70.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@davemooreuws davemooreuws mentioned this pull request Oct 20, 2023
Draft
tjholm
tjholm previously requested changes Oct 23, 2023
View reviewed changes
@davemooreuws davemooreuws force-pushed the feat/api-cors branch 2 times, most recently from d4d7842 to a02b4eb Compare October 24, 2023 00:22
@davemooreuws davemooreuws requested a review from tjholm October 24, 2023 00:22
@davemooreuws davemooreuws requested a review from tjholm October 24, 2023 00:57
@davemooreuws davemooreuws requested a review from tjholm November 3, 2023 03:30
@davemooreuws davemooreuws force-pushed the feat/api-cors branch 10 times, most recently from d586680 to 5371e04 Compare November 4, 2023 04:13
@davemooreuws davemooreuws marked this pull request as ready for review November 5, 2023 22:21
@davemooreuws davemooreuws mentioned this pull request Nov 5, 2023
Open
@davemooreuws
Copy link
Member Author

closing for new PR

@jyecusch jyecusch deleted the feat/api-cors branch July 4, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjholm tjholm Awaiting requested review from tjholm tjholm is a code owner

@jyecusch jyecusch Awaiting requested review from jyecusch jyecusch is a code owner

@HomelessDinosaur HomelessDinosaur Awaiting requested review from HomelessDinosaur

Assignees

@jyecusch jyecusch

@tjholm tjholm

@HomelessDinosaur HomelessDinosaur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davemooreuws @tjholm @jyecusch @HomelessDinosaur