-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build-dependencies resolution when cross-compiling #372
Fix build-dependencies resolution when cross-compiling #372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this looks very nice!
@Ericson2314 I changed a few things since the opening of the PR: the diff is now smaller and the changes are clearer IMO. I do add a |
@alyssais you have any thoughts on the |
Using rustcTarget as this does seems like the right thing. |
OK I see what is going on. This would technically allow |
This fixes some errors in the resolution of build-dependencies when cross-compiling. All dependencies were computed using the host platform, even build-dependencies which are then compiled for the build platform. I added a minimized example that highlights the issue.