modules/services/dropbox.nix: fix dropbox service #5923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tph5595
changed the title
modules/services/dropbox.nix
Outdated
|
|
||
| systemd.user.services.dropbox = { | ||
| Unit = { Description = "dropbox"; }; | ||
|
|
||
| Install = { WantedBy = [ "default.target" ]; }; | ||
|
|
||
| Service = { | ||
| Environment = [ "HOME=${homeBaseDir}" "DISPLAY=" ]; | ||
| Environment = [ "HOME=${homeBaseDir}" "LD_LIBRARY_PATH=${pkgs.libGL}/lib/"]; |
There was a problem hiding this comment.
This should be fixed in the package
There was a problem hiding this comment.
How do I do that? Sorry this is my first contribution.
There was a problem hiding this comment.
@ttuegel Can you help me with this?
There was a problem hiding this comment.
This should be fixed in the package
@SuperSandro2000
This has been fixed. Is this ready to be merged?
The dropbox-cli package is not well maintained and no longer works as used here. The dropbox package has more support and is currently working. As such, these changes switch the system from dropbox-cli to dropbox.
rycee
reviewed
Oct 20, 2024
| homeBaseDir = "${config.home.homeDirectory}/${baseDir}"; | ||
|
|
||
| in { | ||
| meta.maintainers = [ maintainers.eyjhb ]; | ||
| meta.maintainers = [ maintainers.tph5595 ]; |
There was a problem hiding this comment.
Since you are not in the Nixpkgs repo maintainer list, you will have to add yourself to the modules/lib/maintainers.nix file and change this line to
Suggested change
| meta.maintainers = [ maintainers.tph5595 ]; | |
| meta.maintainers = [ hm.maintainers.tph5595 ]; |
No need to add real name if you feel uncomfortable with that, your GitHub user ID is 6002071:
$ curl -s https://api.github.com/users/tph5595 | jq .id
6002071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dropbox service does not work because it uses
dropbox-cliand notdropbox. This changes the service to usedropboxonly. Additionally, the old maintainer is not active (NixOS/nixpkgs#235345 (comment)) so I added myself as the maintainer.Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
Maintainer CC
@eyJhb