Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yazi: set default integration values for Nushell, Fish, and Zsh to true #5986

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

no-mood
Copy link

@no-mood no-mood commented Oct 21, 2024

The programs.yazi.enableNushellIntegration, programs.yazi.enableFishIntegration, and programs.yazi.enableZshIntegration options were previously set to false by default.

I didn't find a clear convention, but most of the modules I reviewed set these options to true by default. Following this pattern, it seems more appropriate to enable these integrations by default to enhance the user experience.

Description

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

Previously, `programs.yazi.enableNushellIntegration`, `programs.yazi.enableFishIntegration`, and `programs.yazi.enableZshIntegration` were set to false by default.
It seems more appropriate to enable these integrations by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant