proton-ge-rtsp-bin: update to 9-22-rtsp-17 and prevent steam settings… #300
Conversation
|
|
||
| src = fetchzip { | ||
| url = "https://github.com/SpookySkeletons/proton-ge-rtsp/releases/download/${finalAttrs.version}/${finalAttrs.version}.tar.gz"; | ||
| hash = "sha256-iq7oiDW5+51wzqYwASOGSV922c/pg1k29MdkIXlT34k="; | ||
| }; | ||
|
|
||
| postBuild = '' | ||
| # prevents steam from resetting compatability settings (in addition to upstream's modifications) | ||
| sed -i -r 's|GE-Proton-rtsp[0-9]*|GE-Proton-rtsp|' $steamcompattool/compatibilitytool.vdf |
There was a problem hiding this comment.
I'd prefer this to use substituteInPlace. You would have to change it from being a regex to a regular string substitution using the metadata we already have in the derivation
There was a problem hiding this comment.
The upstream package in nixpkgs is already modifying it in the same way. This seems like a simpler way so we don't have to bookkeep the correct rtsp version
There was a problem hiding this comment.
But anyway, changed
There was a problem hiding this comment.
Nvm, regex doesn't work with substituteInPlace, or I don't know how to correctly use it if there is a way
There was a problem hiding this comment.
Does this sed even work?
The file shows the following display name in my local copy: GE-Proton9-22-rtsp17. Quite conveniently, this is the exact value of version. We should be able to use substituteInPlace here
RTUnreal
force-pushed
the
update-proton-rtsp
branch
2 times, most recently
from
dcff605 to
c056304
Compare
|
|
||
| src = fetchzip { | ||
| url = "https://github.com/SpookySkeletons/proton-ge-rtsp/releases/download/${finalAttrs.version}/${finalAttrs.version}.tar.gz"; | ||
| hash = "sha256-iq7oiDW5+51wzqYwASOGSV922c/pg1k29MdkIXlT34k="; | ||
| }; | ||
|
|
||
| postBuild = '' | ||
| # prevents steam from resetting compatability settings (in addition to upstream's modifications) | ||
| sed -i -r 's|GE-Proton-rtsp[0-9]*|GE-Proton-rtsp|' $steamcompattool/compatibilitytool.vdf |
There was a problem hiding this comment.
Does this sed even work?
The file shows the following display name in my local copy: GE-Proton9-22-rtsp17. Quite conveniently, this is the exact value of version. We should be able to use substituteInPlace here
… breaking after update
RTUnreal
force-pushed
the
update-proton-rtsp
branch
from
c056304 to
cb9f2e5
Compare
… breaking after update