Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: scope the package under private registry #1

Open
wants to merge 1 commit into
base: nbt-prod
Choose a base branch
from

Conversation

jorgenader
Copy link

No description provided.

@jorgenader jorgenader force-pushed the NBTC-778 branch 11 times, most recently from 1203878 to b0795dd Compare September 1, 2022 11:46
@jorgenader jorgenader changed the base branch from master to nbt-prod September 1, 2022 11:49
Copy link

@Marvedog Marvedog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should prolly make a task to fix the open source vulnerabilties. Otherwise, everything is good.


variables:
- name: nodeVersion
value: "14.19.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use node 16 like we use for the frontend repo now

@@ -1,5 +1,5 @@
{
"name": "react-native-msal",
"name": "@nbt-private/react-native-msal",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would I get access to this private registry locally? I guess I can follow the instructions in the pipelines portal. But then what about users who do not have access to pipelines?

To me this raises a question, do we even need this to be an actual private registry? Can't we just publish to npm?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that yes might be an issue. workaround would be to have person with access generate api key for pulling - tho this can be a blocker. private registries are behind a paywall in npm but we could switch. if private registry is not important then we can just have a public one just as well.

used what was available to us for free.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preferably, all users involved in the development should have access to Azure Pipelines and consequently access to this private registry so I don't see this as a major blocker.

On the other hand. I have no issue publishing to npm.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this npm org would be required - then we could have public package under for example @nbt scope - think this would be fine. @Marvedog let me know what you think

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds fine. We can create an npm organization that we can use for this tommorow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants