-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for merge queues (merge_group events) #100
Conversation
likely addresses #90 (though I haven't gone through it closely) |
up! |
2b77efd
to
3135d79
Compare
8db3862
to
116930e
Compare
Thank you for this PR! |
Thanks @meeroslav! I see that you've removed the option to opt-in to the special |
So far, we have not had proper support for |
The opt in flag was for the special "branch name parsing to get the merge base" logic. Imo generic merge group behaviour should be enabled and available (by default / always - in the same was as pull requests), but it's this extra bit I was asking about |
Motivation:
nx-set-shas lacks support for github's merge queues
Modification:
eventName === 'merge_group'
andmerge-queue-base-from-pr
input set totrue
, set theBASE_SHA
to themerge-base
of the the default branch + PR's branchNotes / disclaimer:
merge_group
webhook payload does not include it explicitlymerge-queue-base-from-pr
on merge queues with the limit set greater than 1 is not recommended (will probably not work as expected).