Skip to content

Commit

Permalink
update example to remove gh environment (#15)
Browse files Browse the repository at this point in the history
remove gh-prod environment restriction on production deployment IAM role
  • Loading branch information
ntno authored Dec 28, 2022
1 parent 1a9ab33 commit 40ab15b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ temporary environments are created/destroyed with pull request open/close

url: posted to the pull request for review
status:
[![Test Pull Request](https://github.com/ntno/mkdocs-demo/actions/workflows/test-pr.yml/badge.svg?event=pull_request)](https://github.com/ntno/mkdocs-demo/actions/workflows/test-pr.yml)
[![Test Pull Request](https://github.com/ntno/mkdocs-demo/actions/workflows/test-pr.yml/badge.svg)](https://github.com/ntno/mkdocs-demo/actions/workflows/test-pr.yml)

### development
url: [http://factually-settled-boxer-development.s3-website-us-east-1.amazonaws.com](http://factually-settled-boxer-development.s3-website-us-east-1.amazonaws.com)
Expand Down
11 changes: 4 additions & 7 deletions infra/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ locals {
dev_site_name = format("%s-development", local.site_name)
artifact_bucket_name = format("%s-artifacts", local.site_name)
global_tags = {
CreatedBy = "mkdocs-demo"
CreatedBy = "ntno/mkdocs-demo"
Provisioner = "Terraform"
project = "mkdocs-demo"
domain = "personal"
Expand All @@ -57,26 +57,23 @@ module "demo_site_cicd" {
integration_environment = {
environment_id = "integration"
ci_prefix = format("%s-%s-ci-pr-", var.github_org, var.github_repo)
# github_environment_name = "gh-ci"
tags = {
project-environment = "integration"
}
}

deployment_environments = {
"production" = {
github_environment_name = "gh-prod"
deploy_bucket = local.site_name
deploy_bucket = local.site_name
tags = {
project-environment = "production"
}
},
"development" = {
# github_environment_name = "gh-dev"
deploy_bucket = local.dev_site_name
deploy_bucket = local.dev_site_name
tags = {
project-environment = "development"
}
}
}
}
}

0 comments on commit 40ab15b

Please sign in to comment.