set auth provider as firebase #604
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
認証機能の追加に伴い、e2eテストが失敗していた問題の対応
VITE_AUTH_SERVICEが設定されていなかったのでfirebaseにセット経緯・意図・意思決定
認証機能でsupabaseに対応した影響で、VITE_AUTH_SERVICE の環境変数により認証プロバイダーを設定する仕組みになっていたが追従できていなかったことの修正
テストで以下のエラーが発生していた
https://github.com/nttcom/threatconnectome/actions/runs/13568851478/job/37928333575#step:8:141
参考文献