Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/fix docker compose supabase test #605

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Bugfix/fix docker compose supabase test #605

merged 3 commits into from
Feb 28, 2025
+6 −5

Conversation

TsurutaYoshiki
Copy link
Collaborator

PR の目的

  • docker-compose -supabase-test.ymlで間違っていた部分を修正しました。

経緯・意図・意思決定

  • supabase-dbのポートを5432番に直し、docker-compose-supabase-local.ymlと同じになるようにしました。
  • testapiコンテナにある環境変数 TESTDB_HOST: testdbを追加しました。

@TsurutaYoshiki TsurutaYoshiki marked this pull request as ready for review February 28, 2025 07:05
mshim03
mshim03 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@mshim03 mshim03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshim03 mshim03 merged commit afa1a9a into main Feb 28, 2025
3 checks passed
@mshim03 mshim03 deleted the bugfix/fix-docker-compose-supabase-test branch February 28, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshim03 mshim03 mshim03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TsurutaYoshiki @mshim03