Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module)!: default version to v5 #436

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

reslear
Copy link
Contributor

@reslear reslear commented Oct 16, 2024

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

part of #434

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link

netlify bot commented Oct 16, 2024

👷 Deploy request for nuxt-strapi-module pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 73a6f23

@benjamincanac
Copy link
Member

Could be worth changing the docs as well! https://strapi.nuxtjs.org/setup#version

@reslear
Copy link
Contributor Author

reslear commented Oct 16, 2024

@benjamincanac I also went through all the pages

but I think we need to go through and mention replacing id with documentId.
what do you think?

@benjamincanac benjamincanac changed the title fix!: default version is v5 fix(module)!: default version to v5 Oct 16, 2024
@benjamincanac
Copy link
Member

It can be done in another PR I guess! Thanks a lot 😊

@benjamincanac benjamincanac merged commit f53bdf9 into nuxt-modules:dev Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants