Fixes #2923 #2930
Open
Fixes #2923 #2930
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess injecting a label is considered bad form, but have done it anyway. Aim at least is a temp hack. |
Classification now on Cell. Have added label to BFO term (bad form I know, but attempt to circumvent checks.
…cell-ontology into Upper_ontology_fix
|
This is not how you do it with ODK; I don't understand what your proposed solution is here: simply adding BFO as an import and punt the "above the shoreline" discussion for later? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that dangling terms are considered bad when declared in the ontology, but tolerated in imports.