Attempt to work around Unix.socketpair issue on Win32
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polytypic
force-pushed
the
win32-socketpair-workaround
branch
from
78972fb to
50f984a
Compare
`Unix.socketpair` occasionally fails on Windows:
```diff
--- a/_build/default/lib/picos_io/picos_io.mli
+++ b/_build/default/lib/picos_io/.mdx/picos_io.mli.corrected
@@ -753,7 +753,5 @@ end
send_string "Hello, world!";
send_string "POSIX with OCaml";
end
- Hello, world!
- POSIX with OCaml
- - : unit = ()
+ Exception: Unix.Unix_error(Unix.EADDRINUSE, "socketpair", "")
]} *)
```
This introduces a work around to retry `Unix.sockepair` a few times on Win32
when the `EADDRINUSE` error is raised. We shuld remove the workaround once the
root issue is fixed.
polytypic
force-pushed
the
win32-socketpair-workaround
branch
from
50f984a to
0732807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unix.socketpairoccasionally fails on Windows:This introduces a workaround to retry
Unix.socketpaira few times to avoid random CI failures #259.