Don't exit when qpdf repairs the file successfully but displays warning #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good - thanks. |
jbarlow83
added a commit
that referenced
this pull request
Dec 17, 2015
Don't exit when qpdf repairs the file successfully but displays warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCRmyPDF exits when a PDF file is a little bit broken but is successfully repaired by qpdf. I think it should just display the warning and continue.
Here's a sample error display:
WARNING: /home/shemgp/Desktop/Rusli Heince - Clearance.pdf: reported number of objects (7) inconsistent with actual number of objects (8)
WARNING: /home/shemgp/Desktop/Rusli Heince - Clearance.pdf: file is damaged
WARNING: /home/shemgp/Desktop/Rusli Heince - Clearance.pdf (object 5 0, file position 446097): expected 5 0 obj
WARNING: /home/shemgp/Desktop/Rusli Heince - Clearance.pdf: Attempting to reconstruct cross-reference table
WARNING: /home/shemgp/Desktop/Rusli Heince - Clearance.pdf (object 2 0, file position 445846): stream keyword followed by carriage return only
WARNING: /home/shemgp/Desktop/Rusli Heince - Clearance.pdf (object 1 0, file position 176): stream keyword followed by carriage return only
qpdf: operation succeeded with warnings; resulting file may have some problems