souligner le bon lien en fonction de la page courante (active) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trollepierre
force-pushed
the
active
branch
2 times, most recently
from
bff386c to
aca997b
Compare
pierrettebertrand
requested changes
Apr 6, 2017
There was a problem hiding this comment.
Pierre c'est cool que tu as remonté la navbar bien joué !
Ensuite j'ai creusé un peu plus (demain fait moi penser à te parler de boolean) et je suis tombée sur NavLink dans le react router. Un composant qui gère tout seul le côté actif ou pas :)
Il m'embête juste avec le css :(
On voit ça demain, merci encore c'est top !
added 2 commits
April 11, 2017 17:00
penser à ajouter onHomepage à false on about page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Il faudra vérifier après l'intégration des CSS (Roman) l'icône de déconnexion et le soulignage (trop important pour le moment)