fix: avoid log stacktrace when run alongside OtherAagent (#2117)

instrumentor/controllers/instrumentationdevice/collectorsgroup_controller.go

@@ -22,6 +22,7 @@ import (
 
 	odigosv1 "github.com/odigos-io/odigos/api/odigos/v1alpha1"
 
+	k8sutils "github.com/odigos-io/odigos/k8sutils/pkg/utils"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/runtime"
 	ctrl "sigs.k8s.io/controller-runtime"
@@ -71,6 +72,9 @@ func (r *CollectorsGroupReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 			if apierrors.IsConflict(err) {
 				gotConflict = true
 			}
+			if errors.Is(err, k8sutils.OtherAgentRunError) {
+				continue
+			}
 			reconcileErr = errors.Join(reconcileErr, err)
 		}
 	}

instrumentor/controllers/instrumentationdevice/common.go

@@ -3,7 +3,6 @@ package instrumentationdevice
 import (
 	"context"
 	"errors"
-	"fmt"
 
 	odigosv1 "github.com/odigos-io/odigos/api/odigos/v1alpha1"
 	"github.com/odigos-io/odigos/instrumentor/controllers/utils"
@@ -153,7 +152,7 @@ func addInstrumentationDeviceToWorkload(ctx context.Context, kubeClient client.C
 
 	// if non of the devices were applied due to the presence of another agent, return an error.
 	if deviceNotAppliedDueToPresenceOfAnotherAgent {
-		return fmt.Errorf("device not added to any container due to the presence of another agent"), false
+		return k8sutils.OtherAgentRunError, false
 	}
 
 	if err != nil {

instrumentor/controllers/instrumentationdevice/instrumentationrule_controller.go

@@ -2,8 +2,10 @@ package instrumentationdevice
 
 import (
 	"context"
+	"errors"
 
 	odigosv1 "github.com/odigos-io/odigos/api/odigos/v1alpha1"
+	k8sutils "github.com/odigos-io/odigos/k8sutils/pkg/utils"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/runtime"
 	ctrl "sigs.k8s.io/controller-runtime"
@@ -30,6 +32,8 @@ func (r *InstrumentationRuleReconciler) Reconcile(ctx context.Context, req ctrl.
 		if err != nil {
 			if apierrors.IsConflict(err) {
 				gotConflict = true
+			} else if errors.Is(err, k8sutils.OtherAgentRunError) {
+				continue
 			} else {
 				return ctrl.Result{}, err
 			}

k8sutils/pkg/utils/other_agent.go

@@ -0,0 +1,5 @@
+package utils
+
+import "errors"
+
+var OtherAgentRunError = errors.New("device not added to any container due to the presence of another agent")

k8sutils/pkg/utils/retryonconflict.go

@@ -1,6 +1,8 @@
 package utils
 
 import (
+	nativeErrors "errors"
+
 	"k8s.io/apimachinery/pkg/api/errors"
 	"sigs.k8s.io/controller-runtime/pkg/reconcile"
 )
@@ -20,6 +22,11 @@ func K8SUpdateErrorHandler(err error) (reconcile.Result, error) {
 		// For not found errors, ignore
 		return reconcile.Result{}, nil
 	}
+
+	if nativeErrors.Is(err, OtherAgentRunError) {
+		// For other agent run no need to log the stack trace
+		return reconcile.Result{}, nil
+	}
 	// For other errors, return as is (will log the stack trace)
 	return reconcile.Result{}, err
 }