refactor: inline helper function with comment

instrumentor/controllers/agentenabled/podswebhook/mount.go

@@ -8,22 +8,17 @@ import (
 	corev1 "k8s.io/api/core/v1"
 )
 
-func checkIfMountDirectoryExists(containerSpec *corev1.Container, dir string) bool {
-	for _, volumeMount := range containerSpec.VolumeMounts {
-		if volumeMount.SubPath == dir {
-			return true
-		}
-	}
-	return false
-}
-
 func MountDirectory(containerSpec *corev1.Container, dir string) {
 	// TODO: assuming the directory always starts with {{ODIGOS_AGENTS_DIR}}. This should be validated.
 	// Should we return errors here to validate static values?
 	relativePath := strings.TrimPrefix(dir, distro.AgentPlaceholderDirectory+"/")
-	if checkIfMountDirectoryExists(containerSpec, dir) {
-		// avoid adding the directory volume twice to the container
-		return
+
+	// make sure we are idempotent, not adding ourselves multiple times
+	for _, volumeMount := range containerSpec.VolumeMounts {
+		if volumeMount.SubPath == dir {
+			// the volume is already mounted, do not add it again
+			return
+		}
 	}
 
 	absolutePath := strings.ReplaceAll(dir, distro.AgentPlaceholderDirectory, k8sconsts.OdigosAgentsDirectory)
@@ -35,21 +30,15 @@ func MountDirectory(containerSpec *corev1.Container, dir string) {
 	})
 }
 
-func checkIfVolumExists(pod *corev1.Pod) bool {
+func MountPodVolume(pod *corev1.Pod) {
+
+	// make sure we are idempotent, not adding ourselves multiple times
 	for _, volume := range pod.Spec.Volumes {
 		if volume.Name == k8sconsts.OdigosAgentMountVolumeName {
-			return true
+			// the volume is already mounted, do not add it again
+			return
 		}
 	}
-	return false
-}
-
-func MountPodVolume(pod *corev1.Pod) {
-
-	if checkIfVolumExists(pod) {
-		// avoid adding the volume twice to the pod
-		return
-	}
 
 	pod.Spec.Volumes = append(pod.Spec.Volumes, corev1.Volume{
 		Name: k8sconsts.OdigosAgentMountVolumeName,