Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHEL dockerfiles to regular build CI #2394

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Feb 5, 2025

No description provided.

@damemi damemi force-pushed the rhel-dockerfile-ci branch from 5faa637 to 05df441 Compare February 5, 2025 15:50
@damemi damemi force-pushed the rhel-dockerfile-ci branch from 05df441 to 72a1291 Compare February 5, 2025 15:51
@damemi damemi enabled auto-merge (squash) February 5, 2025 17:19
@edeNFed
Copy link
Contributor

edeNFed commented Feb 5, 2025

Are you sure it's not too much to build both on every PR? What do you think about instead adding a check that checks the diff between Dockerfile and the rhel Docketfile to avoid drifting

@damemi
Copy link
Contributor Author

damemi commented Feb 5, 2025

@edeNFed it is a lot, but there are differences between the two files that we want (the base image and labels, but we could probably ignore those). But changes that aren't related to the dockerfile could break too, like #2393

Copy link
Collaborator

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too am not sure if we need to run all that in each PR, but suggest we merge it in so we have coverage for now, know of issues early and better estimate it's behavior.

We can always review what we want to test in each PR and move some things to a nightly / before release, so we test thoroughly less frequently?

I guess running all 3 k8s versions and all the e2e tests with each PR might be something we also want to reconsider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants