-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RHEL dockerfiles to regular build CI #2394
base: main
Are you sure you want to change the base?
Conversation
5faa637
to
05df441
Compare
05df441
to
72a1291
Compare
Are you sure it's not too much to build both on every PR? What do you think about instead adding a check that checks the diff between Dockerfile and the rhel Docketfile to avoid drifting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I too am not sure if we need to run all that in each PR, but suggest we merge it in so we have coverage for now, know of issues early and better estimate it's behavior.
We can always review what we want to test in each PR and move some things to a nightly / before release, so we test thoroughly less frequently?
I guess running all 3 k8s versions and all the e2e tests with each PR might be something we also want to reconsider.
No description provided.