Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-2343]: add K8sAttributes action to Frontend #2423

Merged
merged 17 commits into from
Feb 11, 2025

Conversation

BenElferink
Copy link
Contributor

@BenElferink BenElferink commented Feb 10, 2025

This pull request introduces a new K8sAttributes action type to the codebase, including its schema, model, and resolver implementations. Additionally, the DeleteAttribute action type is removed. The most important changes include the addition of new structs and types, updates to GraphQL schema and resolvers, and changes to the frontend to support the new action type.

Backend Changes:

  • Added K8sAttributes related structs and methods in frontend/graph/model/models_gen.go and frontend/services/actions/k8sattributes.go to handle the new action type [1] [2].
  • Updated GraphQL schema to include K8sAttributes action type definitions in frontend/graph/schema.graphqls.
  • Modified resolver functions in frontend/graph/schema.resolvers.go to support CRUD operations for K8sAttributes [1] [2] [3] [4].

Frontend Changes:

  • Updated TypeScript types and hooks to handle the new K8sAttributes action type in frontend/webapp/@types/actions.ts and frontend/webapp/hooks/actions/useActionCRUD.ts [1] [2] [3] [4].
  • Adjusted imports and type references in various frontend components to accommodate changes in the action types [1] [2] [3].

Dependency Updates:

  • Updated @odigos/ui-containers and @odigos/ui-utils versions in frontend/webapp/package.json.

@BenElferink BenElferink added enhancement New feature or request frontend labels Feb 10, 2025
Copy link

@BenElferink BenElferink enabled auto-merge (squash) February 11, 2025 09:19
@RonFed RonFed disabled auto-merge February 11, 2025 09:51
@RonFed RonFed merged commit 0db998a into odigos-io:main Feb 11, 2025
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants