[GEN-2347]: add Kafka destination #2428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for Kafka as a new destination type in the configuration system. The changes include adding Kafka-specific configuration options, updating utility functions, and modifying documentation to reflect the new destination.
Key changes include:
Kafka Configuration:
Kafkastruct incommon/config/kafka.goto define Kafka-specific settings and methods.common/config/root.goto includeKafkain the list of available configers.Utility Functions:
errorMissingKeyfunction incommon/config/utils.goto handle missing configuration keys.Destination Types:
KafkaDestinationTypeto the list of destination types incommon/dests.go.Documentation and Metadata:
destinations/data/kafka.yamlto define Kafka's configuration fields and display properties.docs/adding-new-dest.mdxanddocs/backends-overview.mdxto include Kafka as a supported destination. [1] [2] [3] [4]