Add code for MDP paper #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Dec 12, 2023
| @@ -1411,6 +1411,15 @@ function construct_belief_update( | |||
| end | |||
| outgoing_belief[node_i] = PY_X * PX / PY | |||
| end | |||
| if length(outgoing_belief) == 2 | |||
| for (node_i, belief) in incoming_belief | |||
| if belief < 1e-6 | |||
There was a problem hiding this comment.
I need to think about this. We encounter numerical issues as we approach the edge of the belief space
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #720 +/- ##
==========================================
+ Coverage 93.40% 93.41% +0.01%
==========================================
Files 27 27
Lines 3397 3404 +7
==========================================
+ Hits 3173 3180 +7
Misses 224 224 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.