Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to add support for permission_conditions #2077

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

exitcode0
Copy link
Contributor

@exitcode0 exitcode0 commented Sep 2, 2024

fixes: #1571

I'm still learning GoLang and thus this PR was heavily aided by Generative AI

I've not written any tests as yet
I would like to get some feedback on what i've done thus far before I write tests for behavior that is incorrect

resource "okta_admin_role_custom" "limited_readonly" {
  label       = "limited readOnly"
  description = "readOnly access to apps, groups, and a subset of user profile attributes"
  permissions = [
    "okta.users.read",
    "okta.groups.read",
    "okta.apps.read",
    ]

  permission_conditions {
    permission = "okta:ResourceAttribute/User/Profile"
    include = ["city", "state", "zipCode"]
    exclude = ["secondEmail", "mobilePhone", "primaryPhone", "postalAddress"]
  }
}

@exitcode0
Copy link
Contributor Author

@duytiennguyen-okta any chance I could trouble you for a code review on this one?

@MichaelOtte-lhsystems
Copy link

What about that feature?
We would like to use this in our automation deployment process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for new EA feature - Custom role "permission conditions"
3 participants