Add OKTETO_SMART_BUILDS_IGNORE_FILES_ENABLED to feature flags #983
Conversation
maroshii
requested review from
codyjlandstrom,
pchico83,
ifbyol and
rlamana
as code owners
✅ Deploy Preview for okteto-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
This is not included in 1.29 release, so wait to merge it cc @codyjlandstrom
| @@ -29,6 +29,7 @@ Below is a list of those variables that you can use to leverage these newer and | |||
| | OKTETO_KUBERNETES_TIMEOUT | Specifies the timeout while deploying | `0` | | |||
| | OKTETO_LOCAL_REGISTRY_STORE_PRIORITY_ENABLED | Gives more priority to the local registry credentials than the Okteto Registry Credentials | `false` | | |||
| | OKTETO_SMART_BUILDS_ENABLED | Enables the [Smart Builds feature](core/build-service.mdx#smart-builds) that uses a hash of the build context to determine if an image needs to be rebuilt or can be pulled from the registry. This can accelerate build times | `true` | | |||
| | OKTETO_SMART_BUILDS_IGNORE_FILES_ENABLED | If set, considers ignores rules in .oktetoignore and .dockerignore for calculating smart build context. | `false` | | |||
There was a problem hiding this comment.
why do we consider .oktetoignore? smart builds only works with dockerignore files, no?
There was a problem hiding this comment.
It was part of the product definition:
Our current Smart Builds implementation only considers changes in the build context. But changes on files referred by .dockerignore or the .oktetoignore files can be ignored.
Improve the logic of Smart Builds to also ignore the changes in files referred by .dockerignore and .oktetoignore for uncommitted changes.
It's pretty straight forward to remove though
There was a problem hiding this comment.
is there a valid case for .oktetoignore? I think it's a bug if we are considering it, but maybe I am missing something
No description provided.