Merge pull request #69 from almirsarajcic/bug-fixes/email-nil

Email without scope
omniauth · Feb 12, 2017 · 1c57c79 · 1c57c79
2 parents 4ae530b + 04e99c7
commit 1c57c79
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/omniauth/strategies/github.rb b/lib/omniauth/strategies/github.rb
@@ -28,7 +28,7 @@ def authorize_params
       info do
         {
           'nickname' => raw_info['login'],
-          'email' => primary_email,
+          'email' => email,
           'name' => raw_info['name'],
           'image' => raw_info['avatar_url'],
           'urls' => {

diff --git a/spec/omniauth/strategies/github_spec.rb b/spec/omniauth/strategies/github_spec.rb
@@ -135,6 +135,14 @@
     end
   end
 
+  context '#info.email' do
+    it 'should use any available email' do
+      allow(subject).to receive(:raw_info).and_return({})
+      allow(subject).to receive(:email).and_return('[email protected]')
+      expect(subject.info['email']).to eq('[email protected]')
+    end
+  end
+
   context '#info.urls' do
     it 'should use html_url from raw_info' do
       allow(subject).to receive(:raw_info).and_return({ 'login' => 'me', 'html_url' => 'http://enterprise/me' })