-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove FluentAssertions #361
chore: remove FluentAssertions #361
Conversation
Signed-off-by: Kyle Julian <[email protected]>
Signed-off-by: Kyle Julian <[email protected]>
* Update CONTRIBUTING.md to fix out of date documentation Signed-off-by: Kyle Julian <[email protected]>
Signed-off-by: Kyle Julian <[email protected]>
Signed-off-by: Kyle Julian <[email protected]>
Signed-off-by: Kyle Julian <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=======================================
Coverage 86.13% 86.13%
=======================================
Files 39 39
Lines 1601 1601
Branches 173 173
=======================================
Hits 1379 1379
Misses 186 186
Partials 36 36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. We should keep the debug messages in case the tests fail so we can easily understand what is happening.
test/OpenFeature.DependencyInjection.Tests/OpenFeatureBuilderExtensionsTests.cs
Show resolved
Hide resolved
test/OpenFeature.DependencyInjection.Tests/OpenFeatureBuilderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
test/OpenFeature.DependencyInjection.Tests/OpenFeatureBuilderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
test/OpenFeature.DependencyInjection.Tests/OpenFeatureBuilderExtensionsTests.cs
Show resolved
Hide resolved
test/OpenFeature.DependencyInjection.Tests/OpenFeatureBuilderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
test/OpenFeature.DependencyInjection.Tests/OpenFeatureBuilderExtensionsTests.cs
Show resolved
Hide resolved
test/OpenFeature.DependencyInjection.Tests/OpenFeatureBuilderExtensionsTests.cs
Show resolved
Hide resolved
Signed-off-by: Kyle Julian <[email protected]>
45ee922
to
a18f425
Compare
Signed-off-by: Kyle Julian <[email protected]>
This PR
Related Issues
Fixes #353
Notes
Follow-up Tasks
How to test