Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove FluentAssertions #361

Merged
merged 10 commits into from
Feb 10, 2025

Conversation

kylejuliandev
Copy link
Contributor

This PR

  • Removes FluentAssertions in unit, integration, and E2E tests
  • Update CONTRIBUTING.md to fix out of date documentation

Related Issues

Fixes #353

Notes

Follow-up Tasks

How to test

@kylejuliandev kylejuliandev requested a review from a team as a code owner January 31, 2025 16:54
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.13%. Comparing base (e74e8e7) to head (7c5f5e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   86.13%   86.13%           
=======================================
  Files          39       39           
  Lines        1601     1601           
  Branches      173      173           
=======================================
  Hits         1379     1379           
  Misses        186      186           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@askpt askpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. We should keep the debug messages in case the tests fail so we can easily understand what is happening.

@kylejuliandev kylejuliandev force-pushed the chore/remove-fluentassertions branch from 45ee922 to a18f425 Compare February 4, 2025 20:06
@askpt askpt added this pull request to the merge queue Feb 10, 2025
Merged via the queue into open-feature:main with commit 4ecfd24 Feb 10, 2025
15 checks passed
@kylejuliandev kylejuliandev deleted the chore/remove-fluentassertions branch February 10, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove FluentAssertions
3 participants