Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update project name in solution file #380

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

askpt
Copy link
Member

@askpt askpt commented Feb 12, 2025

This PR

This pull request includes a small change to the OpenFeature.sln file. The change renames the project from "." to ".root" to fix the current build issues.

Notes

@askpt askpt added the bug Something isn't working label Feb 12, 2025
@askpt askpt requested a review from a team as a code owner February 12, 2025 09:24
@askpt askpt requested review from beeme1mr, toddbaert and a team February 12, 2025 09:25
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.13%. Comparing base (96ba568) to head (424d231).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   86.13%   86.13%           
=======================================
  Files          39       39           
  Lines        1601     1601           
  Branches      173      173           
=======================================
  Hits         1379     1379           
  Misses        186      186           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@askpt askpt enabled auto-merge February 12, 2025 11:27
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what changed that made this an issue now?

@askpt
Copy link
Member Author

askpt commented Feb 12, 2025

Do you know what changed that made this an issue now?

@beeme1mr most likely the sdk update. In our GH actions we setup using 9.0.x. So anything "minor" is used instead of a fixed version.

@askpt askpt added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 1f13258 Feb 13, 2025
15 checks passed
@askpt askpt deleted the askpt/fix-build-issue branch February 13, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants