-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make "we are more than... green squares" slogan accessible #249
Conversation
This reverts commit a2673c3.
Co-authored-by: Lora Rusinouskaya <[email protected]>
Co-authored-by: Lora Rusinouskaya <[email protected]>
Co-authored-by: Lora Rusinouskaya <[email protected]>
Co-authored-by: Lora Rusinouskaya <[email protected]>
Co-authored-by: Lora Rusinouskaya <[email protected]>
Co-authored-by: Lora Rusinouskaya <[email protected]>
Co-authored-by: Lora Rusinouskaya <[email protected]>
Co-authored-by: Lora Rusinouskaya <[email protected]>
✅ Deploy Preview for opensauced-landing ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @nickytonline or @bdougie, can this PR be merged? |
I'm not really understanding the title of this PR and how this addresses the accessibility issue reported. I also can't find the page this is located on in the site. I don't think it's in the production site anymore, at least from navigating around. What page(s) can I go to to test this? |
Hi @nickytonline. @bdougie encouraged me to do a new version of PR #164. It was sitting around for quite some time. This is why the square is no longer present. |
Which page(s) in the deploy preview can I test this on? I can't seem to find it and there's no QA instructions. |
It used to be on the teams page in the website, but I think it went away. |
As it doesn't seem to be used anywhere now, I'm going to go ahead and close this. |
Description
This PR is a new of #164
Note
Read the description section in pull request #164 for more context.
Related Tickets & Documents
Closes #88
Mobile & Desktop Screenshots/Recordings
Note
There is no audio in the below video due to technical difficulties.
green.square.accessibility.test.mov
Steps to QA
Tier (staff will fill in)
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?