Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove height from images #273

Merged
merged 1 commit into from
May 15, 2024
Merged

fix: Remove height from images #273

merged 1 commit into from
May 15, 2024

Conversation

bdougie
Copy link
Member

@bdougie bdougie commented May 15, 2024

Description

It's the same problem I fixed here: #262.

For some reason added a hardcoded height and it sucks.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

before
Screenshot 2024-05-15 at 10 50 59 AM

after
Screenshot 2024-05-15 at 10 51 10 AM

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented May 15, 2024

Deploy Preview for opensauced-landing ready!

Name Link
🔨 Latest commit d7e8dea
🔍 Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/6644f6968d2eb10007eb6343
😎 Deploy Preview https://deploy-preview-273--opensauced-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdougie bdougie merged commit 7a7cc83 into main May 15, 2024
6 checks passed
@bdougie bdougie deleted the blog-square-images branch May 15, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants