Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/sumologicexporter]: Added timeout validation #33522

Merged

Conversation

chan-tim-sumo
Copy link
Contributor

@chan-tim-sumo chan-tim-sumo commented Jun 12, 2024

Description:

Link to tracking Issue:

Testing:

  • Unit test

Documentation:

  • chloggen

@chan-tim-sumo chan-tim-sumo requested review from a team and dmitryax June 12, 2024 20:24
Copy link

linux-foundation-easycla bot commented Jun 12, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@chan-tim-sumo
Copy link
Contributor Author

I think the easy cla check is still failing because I didn't set global user email in git until the most recent commit 🤔

@sumo-drosiek
Copy link
Member

@chan-tim-sumo Please squash commits, maybe it will help with the CLA bot

Copy link
Member

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chan-tim-sumo chan-tim-sumo force-pushed the chan-tim_timeoutValidation branch from 65d1f10 to 6de559d Compare June 13, 2024 16:16
@chan-tim-sumo
Copy link
Contributor Author

oh i think i know why, even though after rebasing to one commit, the first commit's email is:

Author: Tim Chan <[email protected]>

after amending the author to sumo email:

Author: Tim Chan <[email protected]>

@chan-tim-sumo chan-tim-sumo force-pushed the chan-tim_timeoutValidation branch from 6de559d to f793d0c Compare June 13, 2024 16:29
@chan-tim-sumo
Copy link
Contributor Author

can anyone from @open-telemetry/collector-contrib-approvers take a look at this? 😄

@crobert-1
Copy link
Member

If a code owner can check to ensure the new minimum timeout limit looks good, I can add ready to merge. Just want to make sure the change lines up with others' understanding as well. 👍

Copy link
Contributor

@rnishtala-sumo rnishtala-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Jun 17, 2024
@chan-tim-sumo
Copy link
Contributor Author

@dmitryax can you take a look at this? ready to merge :D

@codeboten codeboten merged commit a996c9c into open-telemetry:main Jun 19, 2024
161 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/sumologic ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants