[exporter/datadog] Add feature flag for updated operation and resourc… #36419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
liustanley and
mackjmr
songy23
reviewed
Nov 18, 2024
songy23
reviewed
Nov 18, 2024
| component: datadogexporter | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: "Add a feature gate exporter.datadogexporter.EnableOperationAndResourceNameV2. Enabling this gate modifies the logic for computing operation and resource names from OTLP spans to produce shorter, more readable names and improve alignment with OpenTelemetry specifications." |
There was a problem hiding this comment.
Is there a public doc that we can link here for customers to know exactly what changed?
There was a problem hiding this comment.
Not yet - should I write one up before I merge this?
There was a problem hiding this comment.
Yes, please coordinate with Anna
There was a problem hiding this comment.
In a discussion today, we decided we'll merge first and add a link to the announcement/migration guide afterwards.
There was a problem hiding this comment.
Hi @IbraheemA , customer here :D Where can I find the migration guide, please, I am very interested :)
There was a problem hiding this comment.
Hi @JM89 , thanks for waiting, we've published the guide here: https://docs.datadoghq.com/opentelemetry/guide/migrate_operation_names/?tab=opentelemetrycollector
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
songy23
added
the
never stale
|
@IbraheemA needs a rebase |
IbraheemA
force-pushed
the
ibraheem/add-gate-for-operation-name-v2
branch
from
0ad2755 to
765e1e1
Compare
songy23
reviewed
Jan 9, 2025
songy23
reviewed
Jan 9, 2025
6 tasks
songy23
reviewed
Jan 17, 2025
songy23
approved these changes
Jan 17, 2025
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
open-telemetry#36419) …e name logic <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Datadog associates two name fields with each span: "resource name" and "operation name." Resource name is analogous to `span.name` in OTel, but operation name has no 1:1 correspondence with any OTel fields. (Read more about what operation name respresents here: https://docs.datadoghq.com/tracing/guide/configuring-primary-operation/) Previously, the datadog exporter [would compute operation name as `{scope name}.{span kind}`](https://github.com/DataDog/datadog-agent/blob/8b92185df483f39456c41766b5666a2bd22307e6/pkg/trace/traceutil/otel_util.go#L367). This would result in long, difficult to read operation names in the Datadog UI - [a prior discussion on this issue can be found here](open-telemetry#1909). In this PR, add a feature gate `datadog.EnableOperationAndResourceNameV2`. This gate enables new logic for operation and resource name that improves readability of these fields by producing shorter names and better aligning with the OTel spec. The names computed in the new logic follow those computed in [dd-trace-go](https://github.com/DataDog/dd-trace-go). <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests and E2E tests for the new logic are done in the `datadog-agent` repo. Added a test in this repo that verifies that setting the feature gate enables the new logic; also ran the collector with the feature flag and verified new logic manually. <!--Describe the documentation added.--> #### Documentation Changelog added <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e name logic
Description
Datadog associates two name fields with each span: "resource name" and "operation name." Resource name is analogous to
span.namein OTel, but operation name has no 1:1 correspondence with any OTel fields. (Read more about what operation name respresents here: https://docs.datadoghq.com/tracing/guide/configuring-primary-operation/)Previously, the datadog exporter would compute operation name as
{scope name}.{span kind}. This would result in long, difficult to read operation names in the Datadog UI - a prior discussion on this issue can be found here.In this PR, add a feature gate
datadog.EnableOperationAndResourceNameV2. This gate enables new logic for operation and resource name that improves readability of these fields by producing shorter names and better aligning with the OTel spec.The names computed in the new logic follow those computed in dd-trace-go.
Testing
Unit tests and E2E tests for the new logic are done in the
datadog-agentrepo. Added a test in this repo that verifies that setting the feature gate enables the new logic; also ran the collector with the feature flag and verified new logic manually.Documentation
Changelog added