[chore] Change Makefile updatehelper to not require generated files #37605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid calling make genotelcontribcol genoteltestbedcol unnecessarily
dmitryax
force-pushed
the
update-updatehelper
branch
from
fc2aee9 to
2c796ec
Compare
MovieStoreGuy
approved these changes
Jan 31, 2025
bogdandrutu
reviewed
Jan 31, 2025
Comment on lines
+396
to
+400
| found="false"; \ | ||
| for gomod in $$(find . -name 'go.mod'); do \ | ||
| if grep -qF "$$line" "$$gomod"; then \ | ||
| found="true"; \ | ||
| package=$$(grep -F "$$line" "$$gomod" | head -n 1 | awk '{print $$1}'); \ |
There was a problem hiding this comment.
Not sure if this work, because for example no other module depends on zpages.
There was a problem hiding this comment.
Yeah, I figured that as well after trying this out
songy23
approved these changes
Jan 31, 2025
|
I'm going to try something else, since not every dependency can be found outside of cmd/otelcontribcol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid calling
make genotelcontribcol genoteltestbedcolunnecessarily