Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove null creationTimestamp from CRDs to pass schema validation #1508

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gazal-k
Copy link

@gazal-k gazal-k commented Jan 24, 2025

creationTimestamp would be generated. Setting null does not seem to provide any benefit. It does fail schema validation using tools like https://github.com/yannh/kubeconform. So, remove the field.

`creationTimestamp` would be generated. Setting null does not seem to provide any benefit. It does fail schema validation using tools like https://github.com/yannh/kubeconform. So, remove the field.
@gazal-k gazal-k requested review from Allex1 and a team as code owners January 24, 2025 03:16
@gazal-k
Copy link
Author

gazal-k commented Jan 24, 2025

Looks like the CRDs should be updated in https://github.com/open-telemetry/opentelemetry-operator/tree/main/bundle/community/manifests first 🤔 Shall create a PR for that.

@dmitryax
Copy link
Member

@gazal-k, yes. If you have a chance, please submit a PR upsteam

@gazal-k
Copy link
Author

gazal-k commented Jan 24, 2025

https://github.com/open-telemetry/opentelemetry-operator/tree/main/bundle/ seems to be all generated. It seems to be using kustomize, it's not just creationTimestamp, but the generated CRDs and other resources seem to have status field too, which is puzzling 🤔

e.g:
https://github.com/open-telemetry/opentelemetry-operator/blob/1980f0877e5cff8e41ff3eafafe4c57133d7c899/bundle/community/manifests/opentelemetry.io_instrumentations.yaml#L1886-L1891

status:
  acceptedNames:
    kind: ""
    plural: ""
  conditions: null
  storedVersions: null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants