Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional JSON indent to allow storing data as json-lines #4423

Closed
wants to merge 1 commit into from

Conversation

dimaqq
Copy link

@dimaqq dimaqq commented Feb 10, 2025

Description

Would the OTEL project be open to making JSON identation optional?

That would allow, for example, dumping spans into jsonl files.

Type of change

Please delete options that are not relevant.

  • Relaxation of type hints (minor feature)

How Has This Been Tested?

  • Tested locally, can post code later

Contrib Repo Change?

no

Checklist:

Not yet, let's discuss this first.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

P.S. I'm happy to contribute this change throughout the codebase (also logging, metrics, unit tests, etc.)

Would the OTEL project be open to making JSON identation optional?

That would allow, for example, dumping spans into jsonl files.
@dimaqq dimaqq requested a review from a team as a code owner February 10, 2025 07:09
Copy link

linux-foundation-easycla bot commented Feb 10, 2025

CLA Not Signed

  • ❌ login: @dimaqq / The commit (7ac5f97). This user is authorized, but they must confirm their affiliation with their company. Start the authorization process by clicking here, click "Corporate", select the appropriate company from the list, then confirm your affiliation on the page that appears. For further assistance with EasyCLA, please submit a support request ticket.

@dimaqq
Copy link
Author

dimaqq commented Feb 10, 2025

P.S. just in case it's not clear, indent=None and indent=0 are not the same in json.dumps.

@dimaqq
Copy link
Author

dimaqq commented Feb 12, 2025

On the second thought, I'm not sure if this is worth it.

@dimaqq dimaqq closed this Feb 12, 2025
@dimaqq dimaqq deleted the patch-1 branch February 12, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant