Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog cncf.io repost by OTel CI/CD SIG #5718

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

horovits
Copy link
Contributor

@horovits horovits commented Dec 3, 2024

This is a post by SIG CI/CD Observability, which was posted on cncf.io towards KubeCon NA '24.
Submitting in accordance with the approved issue 5546: #5546

Note: due to lack of support in the OTel blog in embedding social media (thanks @svrnm for the clarification), those embeds from the original CNCF blog have been omitted.
If there's a way to support those, please let me know and I'd be happy to amend.


Preview: https://deploy-preview-5718--opentelemetry.netlify.app/blog/2024/otel-cicd-sig/

@horovits horovits requested a review from a team as a code owner December 3, 2024 09:47
Copy link

linux-foundation-easycla bot commented Dec 3, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first quick review, PTAL

content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style suggestions and copy edits. Thanks!

content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested a review from a team December 4, 2024 10:11
@svrnm
Copy link
Member

svrnm commented Dec 4, 2024

@horovits since you provided that feedback across multiple comments by @tiffany76, I'll address it here:

this is a syndicated article from the CNCF.io blog, I'd rather not change wording unless meaningful.

I disagree with that. We (SIG Comms) allow the re-publication of blog posts from other sources, acknowledging that there are reasons making this necessary, but we will not bend on our standards of quality, this includes that we provide rich copy editing feedback to blog authors. We are very lucky that we have experienced technical writers like @tiffany76 in our SIG who spend time and effort to ensure that. Please reciprocate with spending your time and effort to either accept the feedback or engage in a meaningful discussion.

@svrnm
Copy link
Member

svrnm commented Dec 18, 2024

@horovits please take a look at the feedback provided. Thanks

horovits added a commit to horovits/opentelemetry.io that referenced this pull request Dec 23, 2024
chalin pushed a commit to horovits/opentelemetry.io that referenced this pull request Jan 4, 2025
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we've rolled into 2025, we'll need to decide this this is meant to be cross-posted under a 2024 or 2025 date.

Cf.:

@svrnm
Copy link
Member

svrnm commented Jan 20, 2025

@horovits are you still interested in publishing this blog post, if so please take a look at the review, if not, let us know and we close this PR

@horovits
Copy link
Contributor Author

@horovits are you still interested in publishing this blog post, if so please take a look at the review, if not, let us know and we close this PR

@svrnm all the outstanding review items have been resolved before the turn of the year. The blog post is ready to publish on my part. As to adjusting the year, I'm fine with posting it under 2024 or under 2025, I'll leave it to your discretion.

@svrnm
Copy link
Member

svrnm commented Jan 29, 2025

@svrnm all the outstanding review items have been resolved before the turn of the year. The blog post is ready to publish on my part. As to adjusting the year, I'm fine with posting it under 2024 or under 2025, I'll leave it to your discretion.

There are a few pending remarks:

https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868537275
https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868546418
https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868553787
https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868554342
#5718 (comment)
#5718 (comment)
#5718 (comment)

Some of them got outdated due to other changes, but the first few are still unresolved, please take a look, accept them or comment if you think otherwise. Most of them are linguistic, so we should be able to resolve them quickly.

@opentelemetrybot opentelemetrybot requested a review from a team February 10, 2025 19:19
@horovits
Copy link
Contributor Author

@svrnm Thanks for flagging, pardon my oversight with the outdated ones, indeed no blocker, committing to resolve

@svrnm all the outstanding review items have been resolved before the turn of the year. The blog post is ready to publish on my part. As to adjusting the year, I'm fine with posting it under 2024 or under 2025, I'll leave it to your discretion.

There are a few pending remarks:

https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868537275 https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868546418 https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868553787 https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868554342 #5718 (comment) #5718 (comment) #5718 (comment)

Some of them got outdated due to other changes, but the first few are still unresolved, please take a look, accept them or comment if you think otherwise. Most of them are linguistic, so we should be able to resolve them quickly.

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should help with the spellchecker.

content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested a review from a team February 10, 2025 21:55
@opentelemetrybot opentelemetrybot requested a review from a team February 10, 2025 22:01
@chalin
Copy link
Contributor

chalin commented Feb 10, 2025

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13252323374

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@svrnm
Copy link
Member

svrnm commented Feb 12, 2025

@svrnm Thanks for flagging, pardon my oversight with the outdated ones, indeed no blocker, committing to resolve

No worries, and thanks for addressing them. The PR seems to be stuck on some CI jobs, let me retrigger them

@opentelemetrybot opentelemetrybot requested a review from a team February 17, 2025 10:51
@svrnm
Copy link
Member

svrnm commented Feb 17, 2025

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13370183479

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@opentelemetrybot opentelemetrybot requested a review from a team February 17, 2025 19:26
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
static/refcache.json Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested a review from a team February 17, 2025 19:34
@chalin chalin changed the title new blog by OTel CI/CD SIG - Repost from cncf.io/blogs Blog cncf.io repost by OTel CI/CD SIG Feb 18, 2025
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting closer! 🙌🏻 See inline comments, thx.

Comment on lines +14 to +15

## OpenTelemetry Is Expanding Into CI/CD Observability
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop the pseudo-page title, since the page has a title already. Otherwise, the redundancy looks odd:

image

content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
Comment on lines +282 to +284
OpenTelemetry semantic conventions. Discussion takes place in the CNCF Slack
workspace under the #cicd-o11y channel, and you can chime in on GitHub and join
the CICD SIG weekly calls every Thursday at 0600 PT.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add links here to:

  • CNCF Slack (it doesn't need to be to the channel directly)
  • When you write "chime in on GitHub", where exactly is a reader meant to chime in? Can you link to, say, a community repo, or a repo's discussion section?
  • You write "join the CICD SIG weekly". How can a reader to that? Is there a link to a calendar entry or a meeting minutes document?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you write "chime in on GitHub", where exactly is a reader meant to chime in? Can you link to, say, a community repo, or a repo's discussion section?

@chalin This refers to github issues mentioned throughout the article with their respective links.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then let's direct readers in that way, e.g.:

... you can chime in on any of the GitHub issues mentioned throughout this article

Comment on lines +217 to +222
- Tyler Helmuth – Honeycomb
- Andrzej Stencel – Elastic
- Curtis Robert – Splunk
- Justin Voss
- Kristof Kowalski – Anz Bank
- Mike Sarahan – Nvidia
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been nice to have some links here to GH handles, but that's a "nice to have" (and a lot of work).

Comment on lines +252 to +268
- Yuri Shkuro – Creator of Jaeger, Co-Founder of OpenTelemetry
- Andrea Frittoli – Tekton CD Maintainer, CDEvents Co-creator, IBM
- Emil Bäckmark – CDEvents and Eiffel Maintainer, Ericsson
- Magnus Bäck – Eiffel, Axis Communications
- Liudmila Molkova – Microsoft
- Christopher Kamphaus – Jemmic, Jenkins
- Giordano Ricci – Grafana Labs
- Giovanni Liva – Dynatrace, Keptn
- Ivan Calvo – Elastic, Jenkins
- Armin Ruech – Dynatrace
- Michael Safyan – Google
- Robb Kidd – Honeycomb
- Pablo Chacin – Grafana Labs
- Alexandra Konrad – Elastic
- Alexander Wert – Elastic
- Joao Grassi – Dynatrace
- DJ Gregor – Discover
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been nice to have some links here to GH handles, but that's a "nice to have" (and a lot of work).

@opentelemetrybot opentelemetrybot requested a review from a team February 18, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

6 participants