Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update operator.md #6225

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Update operator.md #6225

merged 2 commits into from
Feb 11, 2025

Conversation

vipinvkmenon
Copy link
Contributor

Update the improper property admissionWebhooks.certManager.create in the file to the correct one.

Fixes #6224

@vipinvkmenon vipinvkmenon requested a review from a team as a code owner February 5, 2025 17:36
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 5, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: vipinvkmenon / name: Vipin Menon (c81c473)
  • ✅ login: tiffany76 / name: Tiffany Hrabusa (5569f35)

@opentelemetrybot opentelemetrybot requested a review from a team February 5, 2025 17:37
@svrnm
Copy link
Member

svrnm commented Feb 6, 2025

thanks @vipinvkmenon ! @open-telemetry/helm-approvers please take a look!

chalin
chalin reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. Can you resolve the conflicts?

image

Rebasing locally should do the trick. I see that this was submitted via GitHub web i/f. If you can't resolve the conflicts easily, we'll do it once this gets approved by the Helm approvers.

@vipinvkmenon
Copy link
Contributor Author

Rebased and Updated

@chalin chalin added the sig-approval-missing Co-owning SIG didn't provide an approval label Feb 7, 2025
@svrnm
Copy link
Member

svrnm commented Feb 10, 2025

@open-telemetry/helm-approvers PTAL!

@vipinvkmenon @chalin
Update operator.md
c81c473 
Correct the documentation for the property
povilasv
povilasv approved these changes Feb 11, 2025
View reviewed changes
Copy link

@povilasv povilasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct, we updated helm chart readme with same command in open-telemetry/opentelemetry-helm-charts@38b8b90

@tiffany76 tiffany76 removed the sig-approval-missing Co-owning SIG didn't provide an approval label Feb 11, 2025
@tiffany76 tiffany76 added this pull request to the merge queue Feb 11, 2025
Merged via the queue into open-telemetry:main with commit c8c0a25 Feb 11, 2025
18 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin left review comments

@povilasv povilasv povilasv approved these changes

@tiffany76 tiffany76 tiffany76 approved these changes

Assignees
No one assigned
Labels
sig:helm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Imporper Configuration setting for the OTEL Operator helm chart installating
6 participants
@vipinvkmenon @svrnm @opentelemetrybot @chalin @povilasv @tiffany76