Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infra] Use Docsy feature to display blog out-of-date banner #6278

Merged
merged 1 commit into from
Feb 10, 2025
Merged

[infra] Use Docsy feature to display blog out-of-date banner #6278

merged 1 commit into from
Feb 10, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 10, 2025

  • Upgrades Docsy
  • Drops custom template overrides in favor of using Docsy's
  • Generates the same site pages (modulo whitespace): 
    $ (cd public && git diff -bw) | grep ^diff
diff --git a/site/index.html b/site/index.html

@chalin chalin requested a review from a team as a code owner February 10, 2025 21:08
@chalin chalin added CI/infra CI & infrastructure docsy labels Feb 10, 2025
tiffany76
tiffany76 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@chalin chalin added this pull request to the merge queue Feb 10, 2025
Merged via the queue into open-telemetry:main with commit d4f11fc Feb 10, 2025
18 checks passed
@chalin chalin deleted the chalin-im-i18n-page-banners-2025-02-10 branch February 10, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffany76 tiffany76 tiffany76 approved these changes

Assignees
No one assigned
Labels
CI/infra CI & infrastructure cleanup/refactoring docsy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @tiffany76