Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[style] Fix contrib/issues list and alert styling #6302

Merged
merged 1 commit into from
Feb 13, 2025
Merged

[style] Fix contrib/issues list and alert styling #6302

merged 1 commit into from
Feb 13, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 13, 2025 •
edited
Loading

  • Fixes the styling of lists and of the "first-timer" alert in Contributing > Issues page
  • Eliminates the prettier-ignore directives because we want as much markdown prettified as possible, esp. across locales
  • Inlines markdown link definitions (to make it a wee bit easier for other locales).
  • Btw, the next alert style adjustments work well in dark mode too.

Preview: https://deploy-preview-6302--opentelemetry.netlify.app/docs/contributing/issues/#fixing-an-existing-issue

Screenshots

Before After
image image

@chalin chalin added cleanup/refactoring design/style Front-end site design / styling labels Feb 13, 2025
@chalin chalin requested a review from a team as a code owner February 13, 2025 00:58
@opentelemetrybot opentelemetrybot requested a review from a team February 13, 2025 00:58
@chalin
Copy link
Contributor Author

chalin commented Feb 13, 2025 •
edited
Loading

Hmm, the "Add component labels" action:

GitHub Actions has encountered an internal error when running your job.

🤷🏼‍♂️ I suppose we can ignore that here.

Edit: re-ran the job and the action was successful.

tiffany76
tiffany76 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@chalin chalin merged commit 0dac041 into open-telemetry:main Feb 13, 2025
18 checks passed
@chalin chalin deleted the chalin-im-misc-style-fixes-2025-02-12 branch February 13, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffany76 tiffany76 tiffany76 approved these changes

Assignees
No one assigned
Labels
cleanup/refactoring design/style Front-end site design / styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @tiffany76