Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n/infra] Introduce include feature with fallback #6309

Merged
merged 2 commits into from
Feb 13, 2025
Merged

[i18n/infra] Introduce include feature with fallback #6309

merged 2 commits into from
Feb 13, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 13, 2025 •
edited
Loading

  • Contributes to Improved i18n support #4467
  • In prep for [i18n] Localize "page not translated" banner #6288
  • Adds an include shortcode
  • Refactors some pages to use the include shortcode for the existing JS browser warning, illustrating how this can be done in other locales, with en as fallback.
  • Drops the corresponding notes entry from the global hugo.yaml config, and localizes the warning include to the JS section of the docs where it is used

Previews:

@chalin chalin added CI/infra CI & infrastructure i18n internationalization labels Feb 13, 2025
@chalin chalin requested a review from a team as a code owner February 13, 2025 17:17
@opentelemetrybot opentelemetrybot requested review from a team February 13, 2025 17:17
@chalin chalin changed the title [i18n/infra] Introduce includes feature with fallback [i18n/infra] Introduce include feature with fallback Feb 13, 2025
This was referenced Feb 13, 2025
Closed
Open
tiffany76
tiffany76 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@chalin
Copy link
Contributor Author

chalin commented Feb 13, 2025

Aside from the added include, the remaining pages were just adapted to use the new feature. There were no content changes. Merging. SIG feedback still welcome.

@chalin chalin added this pull request to the merge queue Feb 13, 2025
Merged via the queue into open-telemetry:main with commit e851eb6 Feb 13, 2025
18 checks passed
@chalin chalin deleted the chalin-im-i18n-and-includes-2025-02-13 branch February 13, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffany76 tiffany76 tiffany76 approved these changes

Assignees
No one assigned
Labels
CI/infra CI & infrastructure i18n internationalization lang:pt sig:javascript
Projects
SIG Comms: Docs Translation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @tiffany76