Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[training] Add card for free CNCF/LF course #6312

Merged
merged 4 commits into from
Feb 14, 2025
Merged

[training] Add card for free CNCF/LF course #6312

merged 4 commits into from
Feb 14, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 13, 2025 •
edited
Loading

  • Contributes to Add an OTel training+certs showcase #3463
  • Adds LF course 148 to the courses section. This is a first cut of the addition. There's lots of custom styling that will be cleaned up later.
  • Renames the index file so that it is a page not a section index. Page isn't new, but Git diff can't seem to figure out that it's the same page (with edits) renamed 🤷🏼‍♂️

Preview: https://deploy-preview-6312--opentelemetry.netlify.app/training/

Screenshot

image

@chalin chalin added the enhancement New feature or request label Feb 13, 2025
@chalin chalin requested a review from a team as a code owner February 13, 2025 22:50
@chalin chalin mentioned this pull request Feb 13, 2025
Closed
5 tasks
tiffany76
tiffany76 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic!

content/en/training/index.md Outdated Show resolved Hide resolved
content/en/training/index.md Outdated Show resolved Hide resolved
@chalin
Copy link
Contributor Author

chalin commented Feb 14, 2025

Thanks for the suggestions.

Btw, I'm not sure about the centering of the cards in the page, esp. for wide screens. WDYT? (Maybe I'll adjust it later.)

@tiffany76
Copy link
Contributor

I noticed the centering was off but only after staring at the page for a minute. Maybe when we have more cards, a better layout will present itself.

@chalin chalin force-pushed the chalin-im-training+free-course-2025-02-13 branch from b71c36f to 4ff0fb9 Compare February 14, 2025 06:07
@chalin chalin merged commit dba9867 into open-telemetry:main Feb 14, 2025
18 checks passed
@chalin chalin deleted the chalin-im-training+free-course-2025-02-13 branch February 14, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffany76 tiffany76 tiffany76 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @tiffany76