Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry support for i18n #6320

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 14, 2025

Preview: https://deploy-preview-6320--opentelemetry.netlify.app/ecosystem/registry/

@chalin chalin added CI/infra CI & infrastructure i18n internationalization labels Feb 14, 2025
@chalin chalin requested a review from a team as a code owner February 14, 2025 08:36
@chalin chalin mentioned this pull request Feb 14, 2025
51 tasks
@chalin chalin force-pushed the chalin-im-reg-goes-i18n-2025-02-14 branch from 51bc8e8 to 9c761cd Compare February 14, 2025 08:42
Comment on lines -26 to +34
# {{% param title %}}
<h1>{{% param title %}}</h1>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid the render-heading hook, otherwise the heading is rendered with an anchor self-link.

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@chalin chalin added this pull request to the merge queue Feb 14, 2025
Merged via the queue into open-telemetry:main with commit f235aa0 Feb 14, 2025
18 checks passed
@chalin chalin deleted the chalin-im-reg-goes-i18n-2025-02-14 branch February 14, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure i18n internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants