Rework device events #1880
Rework device events #1880
Conversation
| brief: > | ||
| The iOS platform on which the iOS application is running. | ||
| The iOS platform on which the iOS application is running. | ||
| attributes: | ||
| - id: ios.state |
There was a problem hiding this comment.
I know it's been like this before, but ios.state naming does not seem quite right. It looks like it's a state of iOS and not the app. If we have some other state on ios like ios.wifi.state, it would be even more confusing to have ios.state without any additional qualifier.
Maybe we can do ios.app.state and andrioid.app.state ?
There was a problem hiding this comment.
It's less confusing when it's simply scope to an event. 🙃
| deprecated: "Moved to a payload field of `device.app.lifecycle`." | ||
| stability: development | ||
| brief: > | ||
| This attribute represents the state of the application. | ||
| note: > | ||
| The iOS lifecycle states are defined in the [UIApplicationDelegate documentation](https://developer.apple.com/documentation/uikit/uiapplicationdelegate), | ||
| and from which the `OS terminology` column values are derived. |
There was a problem hiding this comment.
what are the OS terminology and OS identifiers things?
| @@ -0,0 +1,8 @@ | |||
| change_type: enhancement | |||
There was a problem hiding this comment.
We should mark it as breaking (breaking enhancement) since body fields will no longer be in the payload
There was a problem hiding this comment.
so what's the literal string that should go in here then?
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Also rolls back deprecation for required registry attributes.
Changes
Migrating
device.app.lifecycleevent from usingbodyto using attributes forios.stateandandroid.state. This also requires reintroducing those attributes (which were previously deprecated).Merge requirement checklist
[chore]