Feat: [:feature:auth] - Migrated to CMP #2754
Conversation
|
@Nagarjuna0033 you have forgotten to add Jira ticket number in the PR description |
Nagarjuna0033
changed the title
There was a problem hiding this comment.
I just want to clarify whether you are following the mobile wallet implementation approach for the CMP project. If so, are you ensuring that it’s being followed correctly? Not everything is the same in this project, so it’s important to be mindful of that. For example, we have some files that are present in both projects, and you’re implementing them exactly the same way. However, for screens that are different, you’re taking a different approach. This could lead to inconsistency and make things messy. It’s crucial to decide on a clear approach beforehand and stick to it for better consistency across every module. Let’s ensure we maintain uniformity in how we handle similar and different components throughout the project.
.../auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/registration/RegistrationScreen.kt
Show resolved
Hide resolved
...mmonMain/kotlin/org/mifos/mobile/feature/auth/registration/RegistrationVerificationScreen.kt
Outdated
Show resolved
Hide resolved
feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/login/LoginScreen.kt
Show resolved
Hide resolved
feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/login/LoginScreen.kt
Outdated
Show resolved
Hide resolved
feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/login/LoginScreen.kt
Outdated
Show resolved
Hide resolved
feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/login/LoginViewModel.kt
Outdated
Show resolved
Hide resolved
feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/login/LoginScreen.kt
Outdated
Show resolved
Hide resolved
feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/login/LoginScreen.kt
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/login/LoginScreen.kt
Show resolved
Hide resolved
feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/login/LoginScreen.kt
Show resolved
Hide resolved
.../auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/registration/RegistrationScreen.kt
Show resolved
Hide resolved
.../auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/registration/RegistrationScreen.kt
Show resolved
Hide resolved
...mmonMain/kotlin/org/mifos/mobile/feature/auth/registration/RegistrationVerificationScreen.kt
Show resolved
Hide resolved
...mmonMain/kotlin/org/mifos/mobile/feature/auth/registration/RegistrationVerificationScreen.kt
Show resolved
Hide resolved
...mmonMain/kotlin/org/mifos/mobile/feature/auth/registration/RegistrationVerificationScreen.kt
Show resolved
Hide resolved
| ), | ||
| ) | ||
| } catch (e: Exception) { | ||
| updateState { it.copy(dialogState = VerificationState.VerificationDialog.Error((e.message ?: Res.string.could_not_register_user_error).toString())) } |
There was a problem hiding this comment.
format this line it's too big
|
@Nagarjuna0033 Can you run the app upload videos and images for all platforms except iOS? Also, I didn’t get a proper answer to my earlier question—instead, I just received a 👍. |
@niyajali I have uploaded video of android, desktop, wasm js, but the error is getting while running web js, can you please look into this |
|
@Nagarjuna0033 are we able login does API response is 200 and saved token and user info in database, unable to see in video we're just navigating to Register screen while login, at least show some message/log that we successfully logged in, unable to understand did we actually logged in or not.. I know after login we should navigate to passcode screen etc and that doesn't present currently but and just to be sure that it's working fine.. |
|
And for application module setup you could send a different PR so we could take a look into it, but it's okay no issues |
|
@Nagarjuna0033 could you please send a separate PR for application module setup and revert your last commit from this PR, and show sample screen/Text on that PR and comment out all feature modules on that PR and also copy workflows/fastlane/fastlane-config from |
Nagarjuna0033
force-pushed
the
migrating-auth-module-to-kmp
branch
from
faa97d1 to
fcff923
Compare
Fixes - Jira-#120
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
mifos_mobile_android.mp4
mifos_mobile_desktop.mp4
mifos_mobile_web.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.