Loan Product views enhancements #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Nov 29, 2023
| @@ -90,10 +90,12 @@ <h3> {{"labels.heading.Account Overview" | translate}} </h3> | |||
| [active]="IRC.isActive"> | |||
| {{"labels.inputs.Interest Rate Chart" | translate }} | |||
There was a problem hiding this comment.
If this is a loan product view enhancement, please do not modify the fixed deposit account view... Raise a new PR for these changes!
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
adamsaghy
requested changes
Nov 29, 2023
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_refactor
branch
from
89e1ecc to
a2f596f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loan Product views enhancements to avoid duplicates in code/views and include typescript models
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.